Let #summary_wrapper expend its height when summary line-wraps

Review Request #3784 — Created Jan. 19, 2013 and submitted

Information

Review Board
master

Reviewers

Remove height attribute for #summary_wrapper, so it will expend its height when summery line-wraps

The screenshot can be compared with the one I posted in the issue. 
Short summery, OK.
short Summery editing, OK. 

Long summery, OK. 
Long Summery editing, input text-field's width is oversize, but it is not due to this change. Can be fixed as another issue. 

All Summery after edit, Perfect. 

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/css/reviews.less
    
    
  2. 
      
GR
david
  1. Can you add before/after screenshots for when the text is one line?
    1. The pic can be found on the issue 
      
      direct pic link: http://reviewboard.googlecode.com/issues/attachment?aid=28710000000&name=QQ20130119-2.png&token=JdmKyecZ_XAf5cjPVoumaVZb4Mk%3A1358740938717&inline=1
      
      related review request page: http://reviews.reviewboard.org/r/3769/
      
    2. What I meant was, after your change, what does it look like with just a short summary?
  2. 
      
GR
chipx86
  1. I noticed the OK/Cancel buttons are overflowing. That's not ideal, so that may need to be figured out. I can't tell from that screenshot, though, if that's just because the window is so small that some minimum width is being enforced.
    1. There is a `min-width` specified dynamically, looks like something bellow
      
          <form class="inline-editor-form summary-editor" style="display: inline;">
              <input type="text" style="min-width: 546px; width: 1011px;">
              <div class="buttons" style="display: inline;">
                  <input type="button" value="OK" class="save">
                  <input type="button" value="Cancel" class="cancel">
              </div>
          </form>
      
      The editing textfield definitely needs some tweaks, and this may not be the only one. But overall, I think this should be fixed as another issue. I will dig into that a bit later. 
      
      This review request is focusing on the `#summary_wrapper`'s height, not textfield's width. 
    2. Fair enough.
  2. 
      
chipx86
  1. Ship It!
  2. 
      
GR
Review request changed
Status:
Completed
Change Summary:
Pushed to release-1.7.x (09f90ef)