Summary

Let #summary_wrapper expend its height when summary line-wraps

Review Request #3784 — Created Jan. 19, 2013 and submitted Jan. 27, 2013, 11:17 a.m.

Information

Owner

gregwym

Repository

Review Board

Branch

master

Bugs

2871

Depends On

Reviewers

Groups

reviewboard

People

Description

Remove height attribute for #summary_wrapper, so it will expend its height when summery line-wraps

The screenshot can be compared with the one I posted in the issue.

Testing Done

Short summery, OK.
short Summery editing, OK. 

Long summery, OK. 
Long Summery editing, input text-field's width is oversize, but it is not due to this change. Can be fixed as another issue. 

All Summery after edit, Perfect.

Files

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/css/reviews.less

Change Summary:: Add Screenshot.
Description:: Remove height attribute for #summary_wrapper, so it will expend its height when summery line-wraps
+
+
The screenshot can be compared with the one I posted in the issue.
Added Files:

Can you add before/after screenshots for when the text is one line?

gregwym Jan. 20, 2013, 8:03 p.m.

The pic can be found on the issue 

direct pic link: http://reviewboard.googlecode.com/issues/attachment?aid=28710000000&name=QQ20130119-2.png&token=JdmKyecZ_XAf5cjPVoumaVZb4Mk%3A1358740938717&inline=1

related review request page: http://reviews.reviewboard.org/r/3769/

david Jan. 20, 2013, 8:11 p.m.

What I meant was, after your change, what does it look like with just a short summary?

Change Summary:: Add horizontal comparison screenshot for one-line summary, one-line summary editing and multi-line summary. (After fix. in both Chrome and Firefox.)
Testing Done:: ~
Short summery, OK.
~ Long summery, OK.
~ Summery editing, input text-field's width is oversize, but it is not due to this change. Can be fixed as another issue.
~ Summery after edit, Perfect.
~
Short summery, OK.
~ short Summery editing, OK.
~
~
Long summery, OK.
+ Long Summery editing, input text-field's width is oversize, but it is not due to this change. Can be fixed as another issue.
+
+
All Summery after edit, Perfect.
Added Files:

I noticed the OK/Cancel buttons are overflowing. That's not ideal, so that may need to be figured out. I can't tell from that screenshot, though, if that's just because the window is so small that some minimum width is being enforced.

gregwym Jan. 21, 2013, 11:51 a.m.

There is a `min-width` specified dynamically, looks like something bellow

    <form class="inline-editor-form summary-editor" style="display: inline;">
        <input type="text" style="min-width: 546px; width: 1011px;">
        <div class="buttons" style="display: inline;">
            <input type="button" value="OK" class="save">
            <input type="button" value="Cancel" class="cancel">
        </div>
    </form>

The editing textfield definitely needs some tweaks, and this may not be the only one. But overall, I think this should be fixed as another issue. I will dig into that a bit later. 

This review request is focusing on the `#summary_wrapper`'s height, not textfield's width.

chipx86 Jan. 27, 2013, 11:11 a.m.
```
Fair enough.
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (09f90ef)

		Remove height attribute for #summary_wrapper, so it will expend its height when summery line-wraps
	+
	+	The screenshot can be compared with the one I posted in the issue.

~		Short summery, OK.
~		Long summery, OK.
~		Summery editing, input text-field's width is oversize, but it is not due to this change. Can be fixed as another issue.
~		Summery after edit, Perfect.
	~	Short summery, OK.
	~	short Summery editing, OK.
	~
	~	Long summery, OK.
	+	Long Summery editing, input text-field's width is oversize, but it is not due to this change. Can be fixed as another issue.
	+
	+	All Summery after edit, Perfect.