Fixed bug allowing a request to be published with empty summary fields.

Review Request #3760 — Created Jan. 18, 2013 and submitted

Information

Review Board
master

Reviewers

Fixed bug allowing a request to be published with empty summary fields.

In the publish request page, if you filled the summary or description field then deleted the contents, the fields would not be updated but the ReviewRequest object would be updated.  This allowed a request to be published with empty fields although the page showed they were not empty.

The fields are now emptied to then be filled with the new contents, avoiding this issue.
Checked in browser that the summary and description fields are updated if you empty the field.  The Web UI does not allow the request to be published after the field is emptied.
Description From Last Updated

When we chain multiple things together, we want to format it like this: $("#" + field) .empty() .html(...);

daviddavid
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/static/rb/js/reviews.js (Diff revision 1)
     
     
    Show all issues
    When we chain multiple things together, we want to format it like this:
    
    $("#" + field)
        .empty()
        .html(...);
  3. 
      
MF
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
    
    
  2. 
      
david
  1. Can you verify that the web UI does not allow you to publish after emptying the field?
  2. 
      
MF
david
  1. Ship It!
  2. 
      
MF
Review request changed
Status:
Completed
Change Summary:
Pushed to release-1.7.x (215c12c). Thanks!