Summary

Fixed bug allowing a request to be published with empty summary fields.

Review Request #3760 — Created Jan. 18, 2013 and submitted Jan. 22, 2013, 10:49 p.m.

Information

Owner

mflores

Repository

Review Board

Branch

master

Bugs

2870

Depends On

Reviewers

Groups

reviewboard

People

Description

Fixed bug allowing a request to be published with empty summary fields.

In the publish request page, if you filled the summary or description field then deleted the contents, the fields would not be updated but the ReviewRequest object would be updated.  This allowed a request to be published with empty fields although the page showed they were not empty.

The fields are now emptied to then be filled with the new contents, avoiding this issue.

Testing Done

Checked in browser that the summary and description fields are updated if you empty the field.  The Web UI does not allow the request to be published after the field is emptied.

Issues

Description	From	Last Updated
When we chain multiple things together, we want to format it like this: $("#" + field) .empty() .html(...);	david	Jan. 19, 2013, 10:14 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/reviews.js

reviewboard/static/rb/js/reviews.js (Diff revision 1)

The issue has been resolved. Show all issues

When we chain multiple things together, we want to format it like this:

$("#" + field)
    .empty()
    .html(...);

Change Summary:

Updated to reflect David's review.

Diff:

Revision 2 (+3 -1)

Show changes

reviewboard/static/rb/js/reviews.js

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/reviews.js

Can you verify that the web UI does not allow you to publish after emptying the field?

Change Summary:: Responded to David's question. Added extra verification to the Testing Done field.
Testing Done:: ~
Checked in browser that the summary and description fields are updated if you empty the field.
~
Checked in browser that the summary and description fields are updated if you empty the field. The Web UI does not allow the request to be published after the field is emptied.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (215c12c). Thanks!

~		Checked in browser that the summary and description fields are updated if you empty the field.
	~	Checked in browser that the summary and description fields are updated if you empty the field. The Web UI does not allow the request to be published after the field is emptied.