Fixed bug that did not display error warning when changing fields

Review Request #3756 — Created Jan. 18, 2013 and submitted

Information

Review Board
master

Reviewers

Fixed error that failed to display user-not-found text in red error box.
1. Incorrectly inputted into Group field - error appeared with text.
2. Incorrectly inputted into People field - error appeared with text.
Description From Last Updated

I don't think you need to indent this as much anymore, it should look like: $("#review-request-warning") .show() .html(message);

mike_conleymike_conley

Almost! We want to chain methods like this: $("#review-request-warning") .show() .html(message);

mike_conleymike_conley
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
    
    
  2. 
      
DE
mike_conley
  1. Hey Jon,
    
    Looking great! Just an indentation nit. Perfect opportunity to practice updating a review request.
    
    Good work - make sure you get a t-shirt.
    
    -Mike
  2. reviewboard/static/rb/js/reviews.js (Diff revision 1)
     
     
    I don't think you need to indent this as much anymore, it should look like:
    
    $("#review-request-warning")
        .show()
        .html(message);
  3. 
      
DE
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
    
    
  2. 
      
mike_conley
  1. 
      
  2. reviewboard/static/rb/js/reviews.js (Diff revision 2)
     
     
    Almost!
    
    We want to chain methods like this:
    
    $("#review-request-warning")
        .show()
        .html(message);
  3. 
      
DE
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
    
    
  2. 
      
DE
DE
david
  1. Ship It!
  2. 
      
DE
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (3c5ffba). Thanks!
Loading...