Fixed bug that did not display error warning when changing fields
Review Request #3756 — Created Jan. 18, 2013 and submitted
Fixed error that failed to display user-not-found text in red error box.
1. Incorrectly inputted into Group field - error appeared with text. 2. Incorrectly inputted into People field - error appeared with text.
| Description | From | Last Updated |
|---|---|---|
|
I don't think you need to indent this as much anymore, it should look like: $("#review-request-warning") .show() .html(message); |
 mike_conley
|
|
|
Almost! We want to chain methods like this: $("#review-request-warning") .show() .html(message); |
mike_conley
|
-
Hey Jon, Looking great! Just an indentation nit. Perfect opportunity to practice updating a review request. Good work - make sure you get a t-shirt. -Mike
-
reviewboard/static/rb/js/reviews.js (Diff revision 1) I don't think you need to indent this as much anymore, it should look like: $("#review-request-warning") .show() .html(message);
DE
Change Summary:
Fixed based off review that requested removal of spaced/indented format of the JavaScript function calls.
Diff: |
Revision 2 (+1 -3) |
|---|
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/js/reviews.js
-
-
reviewboard/static/rb/js/reviews.js (Diff revision 2) Almost! We want to chain methods like this: $("#review-request-warning") .show() .html(message);
DE
Change Summary:
Fixed up the spacing style.
Summary: |
|
||||||
|---|---|---|---|---|---|---|---|
Description: |
|
||||||
Diff: |
Revision 3 (+1 -2) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/js/reviews.js
DE
Summary: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||
Testing Done: |
|
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/js/reviews.js