Summary

Fixed bug that did not display error warning when changing fields

Review Request #3756 — Created Jan. 18, 2013 and submitted Feb. 18, 2013, 5:29 p.m.

Information

Owner

Demelo

Repository

Review Board

Branch

master

Bugs

2869

Depends On

Reviewers

Groups

reviewboard

People

Description

Fixed error that failed to display user-not-found text in red error box.

Testing Done

1. Incorrectly inputted into Group field - error appeared with text.
2. Incorrectly inputted into People field - error appeared with text.

Issues

Description	From	Last Updated
I don't think you need to indent this as much anymore, it should look like: $("#review-request-warning") .show() .html(message);	mike_conley	Feb. 18, 2013, 5:26 p.m.
Almost! We want to chain methods like this: $("#review-request-warning") .show() .html(message);	mike_conley	Feb. 18, 2013, 5:13 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/reviews.js

Change Summary:: Added the Bug number.
Bugs:: 2869

Hey Jon,

Looking great! Just an indentation nit. Perfect opportunity to practice updating a review request.

Good work - make sure you get a t-shirt.

-Mike

reviewboard/static/rb/js/reviews.js (Diff revision 1)

The issue has been resolved. Show all issues

I don't think you need to indent this as much anymore, it should look like:

$("#review-request-warning")
    .show()
    .html(message);

Change Summary:

Fixed based off review that requested removal of spaced/indented format of the JavaScript function calls.

Diff:

Revision 2 (+1 -3)

Show changes

reviewboard/static/rb/js/reviews.js

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/reviews.js

reviewboard/static/rb/js/reviews.js (Diff revision 2)

The issue has been resolved. Show all issues

Almost!

We want to chain methods like this:

$("#review-request-warning")
    .show()
    .html(message);

Change Summary:

Fixed up the spacing style.

Summary:

Fixed error that failed to display user-not-found error

Finalized the formatting of the fix

Description:

~		Fixed error that failed to display user-not-found error
	~	Finalized the formatting of the fix

Diff:

Revision 3 (+1 -2)

Show changes

reviewboard/static/rb/js/reviews.js

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/reviews.js

Description:: +
Fixed error that failed to display user-not-found error
+

Finalized the formatting of the fix

Summary:: Finalized the formatting of the fix
Fixed bug that did not display error warning when changing fields
Description:: ~
Fixed error that failed to display user-not-found error
~
Fixed error that failed to display user-not-found text in red error box.
-
-
Finalized the formatting of the fix
Testing Done:: +
Incorrectly inputted into Group field - error appeared with text.
+
Incorrectly inputted into People field - error appeared with text.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (3c5ffba). Thanks!

	+	Incorrectly inputted into Group field - error appeared with text.
	+	Incorrectly inputted into People field - error appeared with text.