Fix file attachment names in changedescs.

Review Request #3747 — Created Jan. 13, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Fix file attachment names in changedescs.

When file attachments are added with no captions, the change descriptions would
just say "Added ". This is pretty horrible. This change adds a new property
which will prefer the caption and fall back on the basename.
Added a file without a filename and published. Checked that the change description
text was the file basename. Gave the file a caption, and then removed it.
Checked that the change description text was the caption.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/attachments/models.py
        reviewboard/reviews/models.py
      Ignored Files:
    
    
  2. 
      
SM
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (9a48495).
Loading...