• 
      

    Add support for moved file handling for Perforce.

    Review Request #3744 — Created Jan. 13, 2013 and submitted

    Information

    Review Board
    release-1.7.x

    Reviewers

    Add support for moved file handling for Perforce.
    
    This adds support for representing moved files properly in Perforce.
    This handles both files moved with and without changes made.
    
    An accompanying change to post-review is needed in order to add moved
    information to the diff format. Like the other fields in Perforce diffs
    we respond to, this is entirely custom, as Perforce doesn't have any
    useful information in p4 diff to provide.
    
    This feature is funded by NetApp, Inc.
    Unit tests pass.
    
    Tested this with the accompanying RBTools change, using a resulting diff
    from a Perforce environment that contained 4 files: 1 new file, 1 moved file
    without changes, 1 new file, and 1 moved file with changes. This order was
    chosen to make sure parsing worked correctly.
    
    In the tests, the moved files appeared with the "(moved)" suffix. The unchanged
    file said that no changes were made to the file. The changed file showed the
    changes only.
    Description From Last Updated

    Col: 23 E221 multiple spaces before operator

    reviewbotreviewbot

    Col: 80 E501 line too long (81 > 79 characters)

    reviewbotreviewbot
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/diffviewer/parser.py
          reviewboard/scmtools/tests.py
          reviewboard/scmtools/perforce.py
        Ignored Files:
      
      
    2. reviewboard/diffviewer/parser.py (Diff revision 1)
       
       
      Show all issues
      Col: 23
       E221 multiple spaces before operator
      
    3. reviewboard/scmtools/tests.py (Diff revision 1)
       
       
      Show all issues
      Col: 80
       E501 line too long (81 > 79 characters)
      
    4. 
        
    SM
    1. Ship It!
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed