-
-
rbtools/clients/perforce.py (Diff revision 1) Col: 17 E128 continuation line under-indented for visual indent
-
rbtools/clients/tests.py (Diff revision 1) Col: 17 E126 continuation line over-indented for hanging indent
Generate proper diffs with moved file information for Perforce.
Review Request #3743 — Created Jan. 13, 2013 and submitted
Generate proper diffs with moved file information for Perforce. Modern versions of Perforce support file move operations. These may either be straight moves, or moves with file changes. We now handle this information and diff the files correctly. We also inject some custom fields indicating the move information, so it can be processed by Review Board. This feature is funded by NetApp, Inc.
Added new unit tests, which test against the moved-files capability being on and off. The tests were based on real-world usage of move operations in Perforce. Tested against a Perforce repository. Simulated moving files without changes, and moving files with changes. Tested the diff with moved file info against Review Board with support for these new diff additions. That patch will go up separately.
| Description | From | Last Updated |
|---|---|---|
|
Col: 17 E128 continuation line under-indented for visual indent |
 reviewbot
|
|
|
Col: 17 E126 continuation line over-indented for hanging indent |
reviewbot
|
|
|
This new new_depot_path parameter is added, but this new parameter is not added to the invocation of _do_diff at the … |
FA Faller.Gyula |
Change Summary:
* Fixed some alignment issues to make Review Bot less mad at me :(
Diff: |
Revision 2 (+221 -20) |
|---|
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/clients/tests.py rbtools/clients/perforce.py Ignored Files:
Change Summary:
* Fixed a breakage I introduced last-minute when converting from execute() to run_p4().
Diff: |
Revision 3 (+221 -20) |
|---|
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/clients/tests.py rbtools/clients/perforce.py Ignored Files:
FA
-
-
rbtools/clients/perforce.py (Diff revision 3) This new new_depot_path parameter is added, but this new parameter is not added to the invocation of _do_diff at the end of the _path_diff!!! If you invoke the _path_diff, the post-review will crash. See error 2892 http://code.google.com/p/reviewboard/issues/detail?id=2892
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/clients/tests.py rbtools/clients/perforce.py Ignored Files: