Review Board Activity widget fails to remove all datasets

Review Request #3725 — Created Jan. 6, 2013 and submitted

bogdana
Review Board
2846
reviewboard
The issue was caused by the plot function not being called when no datasets were selected, which meant the last dataset would always be displayed.
manual check
all automated tests pass
Description From Last Updated

Unindent these lines one level. While you're editing this, care to move this inline to the plot_data.push() call on line ...

daviddavid
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/templates/admin/widgets/w-stats-large.html
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/templates/admin/widgets/w-stats-large.html (Diff revision 1)
     
     
     
     
     
     
     
     
    Unindent these lines one level.
    
    While you're editing this, care to move this inline to the plot_data.push() call on line 186? It's only used in the one place.
  3. 
      
BO
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/templates/admin/widgets/w-stats-large.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
BO
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (bda71b1). Thanks!
Loading...