Summary

Review Board Activity widget fails to remove all datasets

Review Request #3725 — Created Jan. 6, 2013 and submitted Jan. 12, 2013, 12:06 p.m.

Information

Owner

bogdana

Repository

Review Board

Branch

Bugs

2846

Depends On

Reviewers

Groups

reviewboard

People

Description

The issue was caused by the plot function not being called when no datasets were selected, which meant the last dataset would always be displayed.

Testing Done

manual check
all automated tests pass

Issues

Description	From	Last Updated
Unindent these lines one level. While you're editing this, care to move this inline to the plot_data.push() call on line …	david	Jan. 10, 2013, 9:50 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/templates/admin/widgets/w-stats-large.html

reviewboard/templates/admin/widgets/w-stats-large.html (Diff revision 1)

The issue has been resolved. Show all issues

Unindent these lines one level.

While you're editing this, care to move this inline to the plot_data.push() call on line 186? It's only used in the one place.

Change Summary:

Updated according to David's comment.

Diff:

Revision 2 (+10 -2)

Show changes

reviewboard/templates/admin/widgets/w-stats-large.html

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/templates/admin/widgets/w-stats-large.html

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (bda71b1). Thanks!