Summary

Enabling usage of non-standard ssh port (!=22) for connecting to repositories

Review Request #3712 — Created Jan. 3, 2013 and submitted March 3, 2013, 12:45 p.m.

Owner

Repository

Review Board

Branch

release-1.7.x

Bugs

2841

Depends On

Groups

People

Description

Based on "Issue 2841: Using non-standard ssh port (!=22) for connecting to git repository".

Testing Done

Verified that ssh connection is established but other error occurred described in comment #1 in bug report.

Issues

Description	From	Last Updated
This line has trailing whitespace.	david	Jan. 3, 2013, 11:58 p.m.
This would be somewhat cleaner as: hostname, port = netloc.split(':', 1)	david	Jan. 3, 2013, 11:58 p.m.

Looks pretty good. I have just a couple comments:

reviewboard/ssh/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This line has trailing whitespace.
```

reviewboard/ssh/utils.py (Diff revision 1)

The issue has been resolved. Show all issues

This would be somewhat cleaner as:

hostname, port = netloc.split(':', 1)

Change Summary:

Resolved issues below. For some reason, I had to add port = int(port) after the split:

hostname, port = netloc.split(':', 1)
port = int(port)

Diff:

Change Summary:

There was another bug with SSH port handling is rbssh.py which is fixed in the attached patch.

Diff:

	reviewboard/cmdline/rbssh.py
	reviewboard/ssh/utils.py

Ship it!