Enabling usage of non-standard ssh port (!=22) for connecting to repositories

Review Request #3712 — Created Jan. 3, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Based on "Issue 2841: Using non-standard ssh port (!=22) for connecting to git repository".
Verified that ssh connection is established but other error occurred described in comment #1 in bug report.
Description From Last Updated

This line has trailing whitespace.

daviddavid

This would be somewhat cleaner as: hostname, port = netloc.split(':', 1)

daviddavid
david
  1. Looks pretty good. I have just a couple comments:
  2. reviewboard/ssh/utils.py (Diff revision 1)
     
     
    Show all issues
    This line has trailing whitespace.
  3. reviewboard/ssh/utils.py (Diff revision 1)
     
     
     
     
    Show all issues
    This would be somewhat cleaner as:
    
    hostname, port = netloc.split(':', 1)
  4. 
      
MA
MA
chipx86
  1. Ship It!
  2. 
      
MA
Review request changed
Status:
Completed
Change Summary:
Pushed to release-1.7.x (3d3277d)