Add fallbacks for important console.* methods.

Review Request #3703 — Created Dec. 27, 2012 and submitted

Information

Review Board
release-1.7.x

Reviewers

Add fallbacks for important console.* methods.

We can't always rely upon console.log and console.assert existing in the
browser. What's worse is that we can't rely on console.assert behaving
the same way. In Chrome, for instance, a failed assert will log but will
continue on in the function, causing further problems.

We now have an empty fallback for console.log, and a console.assert
wrapper that ensures we throw an exception on a failed assert.

This helps with consistency, and with our unit tests.
Tested in Chrome and Firefox, with existing unit tests depending on
this behavior.
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...