FIx for issue 121. svn cp/mv not handled well by review board.

Review Request #367 — Created April 26, 2008 and submitted — Latest diff uploaded

Information

Review Board SVN (deprecated)
121

Reviewers

This is primarily a patch for http://code.google.com/p/reviewboard/issues/detail?id=121 - along with some relevant refactorings.

Changes include
 * Adding function handle_renames which acts like a filter to fix the svn mv/cp issue.
 * Changed convert_absolute_paths to return a list of results like handle_renames for consistency.
 * Made convert_absolute_paths ignore files which where already had an absolute path
 * added a function svn_info which converts the results of 'svn info filename' to a dict and refactored convert_absolute_paths to use it.
I hacked this together because I had a changeset which did do a lot of svn mv/cp. So thats how I tested these changes.

I also checked that it still worked on vanilla changes without svn mv/cp.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2
/trunk/reviewboard/contrib/tools/post-review
Loading...