• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Update dashboard counts when reopening with a changenum from the form.
    
 
    

    



 
    
 
    

  Review Request #3664
  —
  Created Dec. 14, 2012 and submitted 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-1.6.x
 
    

    





    
 
 
    
  2645
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    Update dashboard counts when reopening with a changenum from the form.

When reopening an existing review request with a change number via post-review,
it would correctly update the dashboard counts. Unfortunately, the
NewReviewRequestForm didn't share this logic, and we weren't passing
update_counts to ReviewRequest.save(). Hopefully this should be the last place
where we have this bug.

Addresses bug 2645.
    
 
    

    





  

    
 
 
    
  
    
 
    

    




 
    

    





    
 
    









 









 
    

    



  
    
 
    

    


    


 













    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    

   
    

    
    





  chipx86
 


    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Seems fine, but it'd be nice to have some unit tests that ensure this.
      
  
      
 
      

 
      
  


      
 
      
 
        

  




      1. 
 
 
        

 

 
        
  
        Yeah, I felt the same, but it's really annoying to do so because this only affects perforce.
        
 
        

        2. 


 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    

   
    

    
    
Review request changed
    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-1.6.x (84c4201).