Removed XML thumbnailing from ReviewBoard

 






 

 


  Review Request #3616
  —
  Created Dec. 3, 2012 and submitted 

 


















 

  

   Information

  





 
 

  slchen
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Removed XML thumbnailing from ReviewBoard

- Removed XML thumbnailing support from ReviewBoard default ship package
  since there is now an XML Extension that integrates both the Review UI
  and Thumbnailing support for XML file attachments into ReviewBoard.
- This effectively reverses the changes in 
  http://reviews.reviewboard.org/r/3567/

 








  


 
 

  
Manually verified that XML file attachments now defaults back to the
TextMimetype and are handled as raw text files for thumbnailing.

(See attached screenshot)

 







 









 





  








 

  
  


   

    

     

     

     

    

   


   

  

 










 






  

 








 














 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Christian is pushing your extension change, so I'll do this one simultaneously.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 SL





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (548a280). release-1.7.x didn't seem to have the original patch. Thanks!





 


 










  

 









     

    

   

  

  

   
   Loading...