• 
      

    Fix regression in linkify js, that is causing certain URLs to be wrongly stripped

    Review Request #3615 — Created Dec. 3, 2012 and submitted

    Information

    Review Board
    master

    Reviewers

    28878fc ( http://reviews.reviewboard.org/r/3374/ ) has introduced a regression in reviewboard URL matching inside review descriptions.
    
    URLs like this (spaces added so this doesn't get stripped):
    http://foo.com/?param1=foo & param2=bar
    
    are currently wrongly converted to:
    http://foo.com/?param1=foo&
    (and last GET parameter is stripped)
    
    I think this was an unintentional change (accidentally stripping the $ sign at the end of the regexp)
    
    Bonus: whitespace fix.
    
    (Note that this is my first patch -- I assume that if I get a "Ship it" some of you guys will push the change. let me know if I need to something else)
    Put the following urls in change description [1]
    See attached screenshots.
    
    [1]:
    
    http://foo.com/?param1=foo & param2=bar
    http://foo.com/?param1=foo&param2=bar()
    (http://foo.com/?param1=foo&param2=bar)
    
    - blah blah (http://www.foo.com/)
    - http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Object.html#clone()
    - http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Object.html#equals(java.lang.Object)
    - gwegdss http://www.foo.com/

    david
    1. Ship It!
    2. 
        
    ES
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.7.x (443f8d3). Thanks!