Comment limit on number of ReviewBot comments

Review Request #3611 — Created Dec. 2, 2012 and submitted

Allyshia
ReviewBot
reviewbot
Providing a new max_comments property to a review that limits the number of comments a review published by ReviewBot can contain in order to avoid excessive commenting to the point of slowing down loading. Using arbitrary value for now.
- manually tested against local dev server: posted a patch to review that contained a long js file (jslint.js) that had more than 30 comments, and ensured that :
1) only 30 comments by JSLint were posted (total, in the entire JSLint review)
2) a descriptive warning was shown in the body_top section of the JSLint review.
Description From Last Updated

Let's remove this blank line

SM smacleod

The spacing is strange here, can you remove the extra spaces at the start so only 1 starts the line.

SM smacleod

Let's change this to: "WARNING: Number of comments exceeded maximum, "

SM smacleod

Can we make this 'Number of' comments

SM smacleod

Can we change this to "The maximum number of comments allowed per review. If a review exceeds this maximum, the ...

SM smacleod
SM
  1. One thing this is missing is a modification to 'extension/reviewbotext/forms.py'
    to add this setting to the ReviewBotSettingsForm. Make sure to explain why we
    need to limit the comments in the help text.
    
    After the form modification, and these small changes, it should be good.
  2. bot/reviewbot/processing/review.py (Diff revision 1)
     
     
    Let's remove this blank line
  3. bot/reviewbot/processing/review.py (Diff revision 1)
     
     
    The spacing is strange here, can you remove the extra spaces at the start so only 1 starts the line.
  4. bot/reviewbot/processing/review.py (Diff revision 1)
     
     
    Let's change this to:
    
    "WARNING: Number of comments exceeded maximum, "
  5. 
      
AL
SM
  1. Really close, just two little nits
  2. bot/reviewbot/processing/review.py (Diff revision 2)
     
     
    Can we make this 'Number of' comments
  3. extension/reviewbotext/forms.py (Diff revision 2)
     
     
     
    Can we change this to "The maximum number of comments allowed per review. If a review exceeds this maximum, the extra comments will be truncated and a warning will be displayed in the review. Large values can cause browsers to slow considerably if a tool generates many comments."
  4. 
      
AL
SM
  1. Ship It!
  2. 
      
AL
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master at https://github.com/smacleod/ReviewBot (148c32c46e).
Loading...