Summary

Comment limit on number of ReviewBot comments

Review Request #3611 — Created Dec. 2, 2012 and submitted Dec. 4, 2012, 4:45 p.m.

Information

Owner

Allyshia

Repository

ReviewBot

Branch

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

Providing a new max_comments property to a review that limits the number of comments a review published by ReviewBot can contain in order to avoid excessive commenting to the point of slowing down loading. Using arbitrary value for now.

Testing Done

- manually tested against local dev server: posted a patch to review that contained a long js file (jslint.js) that had more than 30 comments, and ensured that :
1) only 30 comments by JSLint were posted (total, in the entire JSLint review)
2) a descriptive warning was shown in the body_top section of the JSLint review.

Issues

Description	From	Last Updated
Let's remove this blank line	SM smacleod	Dec. 3, 2012, 3 p.m.
The spacing is strange here, can you remove the extra spaces at the start so only 1 starts the line.	SM smacleod	Dec. 3, 2012, 3 p.m.
Let's change this to: "WARNING: Number of comments exceeded maximum, "	SM smacleod	Dec. 3, 2012, 3:01 p.m.
Can we make this 'Number of' comments	SM smacleod	Dec. 4, 2012, 3:51 p.m.
Can we change this to "The maximum number of comments allowed per review. If a review exceeds this maximum, the …	SM smacleod	Dec. 4, 2012, 3:51 p.m.

One thing this is missing is a modification to 'extension/reviewbotext/forms.py'
to add this setting to the ReviewBotSettingsForm. Make sure to explain why we
need to limit the comments in the help text.

After the form modification, and these small changes, it should be good.

bot/reviewbot/processing/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's remove this blank line
```

bot/reviewbot/processing/review.py (Diff revision 1)

The issue has been resolved. Show all issues

The spacing is strange here, can you remove the extra spaces at the start so only 1 starts the line.

bot/reviewbot/processing/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's change this to:

"WARNING: Number of comments exceeded maximum, "
```

Change Summary:

- some formatting changes
- adding max comments to Review Bot settings form

Diff:

Revision 2 (+17)

Show changes

	bot/reviewbot/processing/review.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/forms.py

```
Really close, just two little nits
```
bot/reviewbot/processing/review.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we make this 'Number of' comments
```

extension/reviewbotext/forms.py (Diff revision 2)

The issue has been resolved. Show all issues

Can we change this to "The maximum number of comments allowed per review. If a review exceeds this maximum, the extra comments will be truncated and a warning will be displayed in the review. Large values can cause browsers to slow considerably if a tool generates many comments."

Change Summary:

String changes to help text

Diff:

Revision 3 (+20)

Show changes

	bot/reviewbot/processing/review.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/forms.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master at https://github.com/smacleod/ReviewBot (148c32c46e).