Escape Subversion URLs

Review Request #361 — Created April 17, 2008 and submitted

Review Board SVN (deprecated)
This patch escapes the URL passed to Subversion so that paths with spaces in them work correctly. Without this, a cryptic "Malformed repository URL" message is shown to the user when submitting via the new review request form.
Verified working with patches to files with spaces in the filenames and spaces in the paths, for both http:// and file:/// repository URLs.
  2. trunk/reviewboard/scmtools/ (Diff revision 1)
    Also, it seems like __normalize_path is a natural place for this to go, instead of here.
    1. Well, yes and no. __normalize_path seems to be about figuring out whether the path is relative to the repo or already includes the repo. Escaping seems like a different task. I'm happy to do it either way though.
    2. OK, I guess that makes sense.  It's fine to leave this here.
  3. trunk/reviewboard/scmtools/ (Diff revision 1)
    Can you add a comment explaining why this is here?
    1. Do you mean the urlsplit or the whole block of code? (the urlsplit is there to avoid escaping the : in http://)
    2. I mean the whole block.
    3. See updated patch
  1. Committed as r1310.  Thanks!