Tweak file attachment styles a little bit more.

Review Request #3586 — Created Nov. 29, 2012 and submitted

david
Review Board
release-1.7.x
reviewboard
Tweak file attachment styles a little bit more.

This change does some small tweaking to the file attachment styles, mostly with
regards to the placement and scaling of the thumbnail images within their
container.
I've been looking at a lot of file attachments lately.
chipx86
  1. Can you add screenshots?
    1. I can but for the general case there's no difference. The specific issues were:
      
      - By using max-height instead of height, really wide screenshots won't be drawn squished.
      - The lack of an explicit height on the header made the placeholder ugly.
      - The spinner isn't vertically centered, which the line-height thing should cover but for some reason still doesn't
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (ed3d8ff).
Loading...