Summary

Tweak file attachment styles a little bit more.

Review Request #3586 — Created Nov. 29, 2012 and submitted Nov. 30, 2012, 1:19 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Tweak file attachment styles a little bit more.

This change does some small tweaking to the file attachment styles, mostly with
regards to the placement and scaling of the thumbnail images within their
container.

Testing Done

I've been looking at a lot of file attachments lately.

Can you add screenshots?

david Nov. 29, 2012, 8:34 p.m.

I can but for the general case there's no difference. The specific issues were:

- By using max-height instead of height, really wide screenshots won't be drawn squished.
- The lack of an explicit height on the header made the placeholder ugly.
- The spinner isn't vertically centered, which the line-height thing should cover but for some reason still doesn't

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (ed3d8ff).