Summary

Syntax-Highlighted Thumbnail Rendering for XML File Attachments

Review Request #3567 — Created Nov. 26, 2012 and submitted Dec. 1, 2012, 11:21 p.m.

Information

Owner

slchen

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Added thumbnail rendering support for XML mimetypes using pygments

Testing Done

Manual Testing on Localhost:
- Uploaded various XML files
- All render correctly with syntax-highlighting

(See attached screenshots: 2012-11-27)

Files

Issues

Description	From	Last Updated
So something we've found in the past is that Pygments's XML rendering is very slow for very large XML files. …	chipx86	Dec. 1, 2012, 10:14 a.m.

reviewboard/attachments/mimetypes.py (Diff revision 1)

The issue has been dropped. Show all issues

So something we've found in the past is that Pygments's XML rendering is very slow for very large XML files. So I'd cap it. If the file is over a certain size (let's say 10KB, which should be defined as a constant on the class), don't highlight it.

slchen

Dec. 1, 2012, 10:14 a.m.

Truncated read on file attachments for thumbnail generation is actually already handled by TextMimetype (base class for XMLMimetype) as part of the Thumbnails project: http://reviews.reviewboard.org/r/3454/

Currently it reads up to `FILE_CROP_CHAR_LIMIT = 2000` from TextMimetype, which is under 10KB. If we'd like a different limit, I can put override the class variable in XMLMimeType.

chipx86

Dec. 1, 2012, 11:19 p.m.
```
Oh, right. Cool.
```

Change Summary:: Added captions for the screenshots of XML Thumbnails
File Captions:: xml_thumbs_1.png:
As rendered in Ubuntu + Chrome at 400% Zoom
xml_thumbs_2.png:
As rendered in Ubuntu + Chrome at 400% Zoom

xml_thumbs_1.png:	As rendered in Ubuntu + Chrome at 400% Zoom
xml_thumbs_2.png:	As rendered in Ubuntu + Chrome at 400% Zoom

Curious, why the zoom? I'd prefer getting an accurate idea of what these look like.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (1d5226c)

I don't know if it's possible without some work, but it would be nice if this was part of the XML Review UI extension.