• 
      

    Allow ReviewUI Integration through ReviewBoard Extensions

    Review Request #3565 — Created Nov. 26, 2012 and submitted

    Information

    Review Board
    master

    Reviewers

    Created a ReviewUIHook to allow extensions to register their 
    own ReviewUIs into ReviewBoard.
    Manually tested with XMLReviewUIExtension: http://reviews.reviewboard.org/r/3564/
    - Successfully installed this extension with its own ReviewUI
    - Succcesfully registered XMLReviewUI through XMLReviewUIHook
    - Once installed, able to review XML file attachments via the "Review" button
    - Color markup for the XML file attachment correctly rendered through pygments

    Description From Last Updated

    These will appear in API docs at some point, so this should be in sentence form, and we shouldn't use …

    chipx86 chipx86
    SL
    chipx86
    1. Looks good! One thing.
    2. reviewboard/extensions/hooks.py (Diff revision 1)
       
       
      Show all issues
      These will appear in API docs at some point, so this should be in sentence form, and we shouldn't use abbreviations. Probably can just drop the "in RB"
      1. I modified the docs as suggested and added a few more details. Please let me know if any of it is inaccurate, and I'll remove or fix them.
    3. 
        
    SL
    chipx86
    1. Ship It!
    2. 
        
    SL
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (ce6197c4)