Summary

Corrected pep8 style

Review Request #3544 — Created Nov. 20, 2012 and discarded July 11, 2014, 4:47 p.m.

Information

Owner

dolanor

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Adding feeds (django 1.4)

Only working for a user in his /dashboard/feed/<username>
This work has been based on the original work available
for reviewboard on previous version working with django 1.2

Testing Done

I tested it on Chromium and Internet Explorer 8.
The RSS feed has been feeding my quite RSS client http://code.google.com/p/quite-rss/

My boss wanted a way to be notified in the systray of new code review without being harrassed by mails.

Issues

Description	From	Last Updated
pep8 style, 2 lines	JS jsintal	Dec. 4, 2012, 9:03 p.m.
pep8 style, 2 lines	JS jsintal	Dec. 4, 2012, 9:03 p.m.
pep8 style, 2 l ines	JS jsintal	Dec. 4, 2012, 9:03 p.m.
pep8 style, 2 lines	JS jsintal	Dec. 4, 2012, 9:03 p.m.

Fix it!

reviewboard/reviews/feeds.py (Diff revision 1)
Show all issues
```
pep8 style, 2 lines
```
reviewboard/reviews/feeds.py (Diff revision 1)
Show all issues
```
pep8 style, 2 lines
```
reviewboard/reviews/feeds.py (Diff revision 1)
Show all issues
```
pep8 style, 2 l ines
```
reviewboard/reviews/feeds.py (Diff revision 1)
Show all issues
```
pep8 style, 2 lines 
```

Looks like a cool feature, however I wish there was some info on testing done or at least a short explanation on how I can use the feature in my dev environment. Although, I think I have an idea. I will try that out.

Change Summary:

Added some testing information (Chromium, IE8 and QuiteRSS)

Testing Done:

	+	I tested it on Chromium and Internet Explorer 8.
	+	The RSS feed has been feeding my quite RSS client http://code.google.com/p/quite-rss/
	+
	+	My boss wanted a way to be notified in the systray of new code review without being harrassed by mails.

Change Summary:

Added the lines to respect pip8 codestyle

Summary:

-	Adding feeds (django 1.4)
+	Corrected pep8 style

Description:

	+	Corrected pep8 style
	+
	+
	+
		Adding feeds (django 1.4)

		Only working for a user in his /dashboard/feed/<username>
		This work has been based on the original work available
		for reviewboard on previous version working with django 1.2

Diff:

Revision 2 (+104 -1)

Show changes

	reviewboard/urls.py
	reviewboard/reviews/feeds.py
	reviewboard/reviews/urls.py

I think your summary and description got messed up. They should describe the overall change, leaving any description of intermediate changes to the "Describe your changes" box in the draft banner.

Change Summary:

Corrected pep8 style

Yeah, the description has been changed because I used the post-review -g flag which used my commit message to add it in the description. I hope it is better now

Description:

-		Corrected pep8 style
-
-
-
		Adding feeds (django 1.4)

		Only working for a user in his /dashboard/feed/<username>
		This work has been based on the original work available
		for reviewboard on previous version working with django 1.2

I like the feature, and the code looks pretty good. How would you feel about trying to make this into an extension, rather than being part of the core product?

dolanor Jan. 23, 2013, 3:22 a.m.

The code isn't really mine, it was just the older code working for previous django that I happened to update to the new version of django. So I'm not really a talented guy, I just read the django updated doc.
I really don't know how to create an extension for reviewboard. I guess it is just about to read docs, but right now, I don't have time, and since it is working at work, I won't be given more time on a feature that works. If I have free time, I might do it, but I can see free time no less than 6 or 8 months ahead ;)

rajasaur Jan. 23, 2013, 8:35 p.m.

Can I take this and convert into an extension. I've started doing couple of extensions that I'm planning to put out and since the code is already here, the task of converting to an extension shouldn't be too hard. Please let know if its okay.

On the patch, I dont see RssGroupReviewsFeed being used, its present in the code but there is no entry in urls.py for this. That could work  for something like /feed/groups/<groupname> .

dolanor Jan. 24, 2013, 2:39 a.m.

I give you full permission on that (even though you could have done it without my permission, it is free software after all ;) But thank you for asking).
If you can make an extension out of that, it would be even better.

In fact, for the RssGroupReviewsFeed, I didn't use it because I had a real focus on 1 person for my work. So if you can add an url to that, it would be better. At least, the code wouldn't be implemented for nothing ;)

dolanor Jan. 24, 2013, 2:45 a.m.

In fact, when rethinking about that, I should have added 2 feeds for users
1 personnal in /dashboard/feed/ to show what you have to do
1 for each user in /users/{username}/feed/ to show what others have in their pipe

and to copy, maybe for groups it should be
/groups/{groupname}/feed/

It would seem more RESTful looking and more coherent with the current data in urls.py

What do you think ?

rajasaur Feb. 9, 2013, 8:01 a.m.

Sorry for not getting back earlier. Ive converted this to an extension and posted it at https://github.com/rajasaur/rb-extension-pack/tree/master/rbrssfeeds. Based on the discussion that we had at https://groups.google.com/forum/#!topic/reviewboard-dev/UhXPAkywZVE, it was arrived that the official rb-extension-pack wont be an area for storing third party extensions, so Ive kept it locally in my rb-extension-pack fork.

dolanor Feb. 10, 2013, 10:19 a.m.

Excellent ! I'll give it a try when I'm installing the real deal !

Review Board 6.0.3 alpha 0 (dev)

Corrected pep8 style

Information

Reviewers

Change Summary:

Testing Done:

Change Summary:

Summary:

Description:

Diff:

Change Summary:

Description:

Status: Discarded