The api bindings were updated recently allowing the use of **kwargs instead of the 'values' argument. Can you change this to:

self.diff = api_root.get_diff(
    review_request_id=self.request_id,
    diff_revision=self.diff_revision).get_patch()

I'd also like to change this so it isn't fetched for every execution. Some tools won't require this, and we don't want to make the request unless they need it.

I know the pep8 tool isn't following the proper capitalization style, but can we switch this to be BuildbotTool.

let's avoid the use of '\' here to break the lines.

You can use the implicit string concatenation inside the dict, and we should also align the second line. Something like:

'help_text': 'The address of the buildmaster. Used by both PB '
             'and SSH',

I don't think a default of True makes sense here.

See above comment about style.

The outside parens aren't aligned properly. I'd just shove the traliling paren up onto the line above.

See above comment about style.

Let's expand a bit and say something more specific about 'improperly stored'.

e.g. The password will be stored as plaintext in the database.

See above about style

See above about style.

This option could pose a problem if a number of workers require unique configurations... We might need to think up a different solution.

See above about style.

Lets alphabetize this.

Alphabetize this as well please.

I don't think we need this newline.

Should we report something instead of failing silently in this case? Is this case even possible?

Nit - add doc

For readability, are you able to indent this so that it's directly beneath the string that it continues? Same below a few times.

This blank line should be put back

lets rename this diff_contents

lets rename this get_diff_file_path

Can we change this to something like:

Runs buildbot try with the review requests diff.

Alphabetize

Alphabetical: 

from reviewbot.tools import Tool
from reviewbot.tools.process import execute

Indentation issue here; I think you want:

cmd = [
    'builtbot',
    'try',
    ...
]

I'm not sure about this one, but I think it might be: 

branch = self.review.api_root.get_review_request(
    review_request_id=self.review.request_id
).branch

Thoughts, mentors?

Indentation issue here:

cmd.extend([
    '--connect=pb',
    '--passwd=%s' % settings['password'],
])

Same comment as above.

Alphabetical