Removed parentheses in autocompleter if suggested user does not have a first and last name

 






 

 


  Review Request #3533
  —
  Created Nov. 19, 2012 and submitted 

 


















 

  

   Information

  





 
 

  CrystalLokKoo
 









 
 

  Review Board
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Removed parentheses in autocompleter if suggested user does not have a first and last name. 

The suggestions show up as "Username (FirstName LastName). If the user does not provide a first/last name, it looks like "Username ()". 

This occurs in RB's main search functionality and in the reviewer's people input field. 

I also have noticed (and mentioned) about the problem with overlapping characters in the autocomplete suggestions with users that have long usernames. I am having a slight issue with finding an elegant solution to changing the size of the widget dynamically. I saw some suggestions in stackoverflow but I am looking for something more elegant.

 








  


 
 

  
Manual Testing. 

Tests include:
- Users with first and last name.
- Users with no first/last name
- Users with only first name
- Users with only last name

 







 









 





  








 









 






  

 








 














 





 

  

   





 JS





   

   





  

 



 

  


   

   

    
 
jsintal


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Performed test where user has First and Last name and no first/last name.

It appears to be working correctly.

I.e. When the user has no first/last name, there is no parentheses in the search autocomplete. If there is a first/last name, then the parentheses show up as expected.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Not sure how to attach screenshots to reviews, but here's proof http://i.imgur.com/9TkGA.png?1 (let me know if it's possible to attach screenshots)
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      And this is what it looked before this patch was applied. http://i.imgur.com/NBFuo.png
      
 
      

      3. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 CR





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (7e006af)





 


 










  

 









     

    

   

  

  

   
   Loading...