Change the FileAttachmentComment API to require an "extra_data." prefix for extra data.

Review Request #3498 — Created Nov. 15, 2012 and submitted

Information

Review Board
master

Reviewers

Change the FileAttachmentComment API to require an "extra_data." prefix for extra data.

Recently, FileAttachmentComment was given support for specifying extra
data to store with a comment. This took any unknown variable and stored
it as extra data, but that meant that typos would also get stored.

Now it requires an "extra_data." prefix for any variables meant to be
stored there. That corresponds to the resulting payload, which is a
dictionary in 'extra_data'.
Unit tests pass.

Tested reviewing an uploaded image. Saving worked, and the comments were loaded
properly when reloading the page.
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (2a8ef6a)
Loading...