Review Board 2.0 RC2 (dev)


Prevent useless comment fetching for screenshots and file attachments.

Review Request #3479 - Created Nov. 7, 2012 and submitted

Information
Christian Hammond
Review Board
release-1.6.x
Reviewers
reviewboard
Prevent useless comment fetching for screenshots and file attachments.

Screenshots and file attachments without comments weren't having their
\_comments variable set, which was causing us to do a fetch later on
for each screenshot and file attachment. We now make sure to always
set \_comments in review_detail, preventing these extra, useless fetches.
Tested on some review requests with many active and inactive screenshots
and file attachments. Saw that the extra queries went away and page load
time decreased.
Review request changed
Updated (Nov. 8, 2012, 2:20 a.m.)

Status: Closed (submitted)

Change Summary:

Pushed to release-1.6.x (c76127e)