Add a get_gravatar_url function in gravatars.

Review Request #3470 — Created Nov. 3, 2012 and submitted

chipx86
Djblets
release-0.6.x
2768
djblets
Add a get_gravatar_url function in gravatars.

This makes it possible to get the URL without generating an <img/> tag.
It also is smart enough to handle HTTP vs. HTTPS, unlike the previous
implementation.
Tested with a change in Review Board.
Description From Last Updated

Is djblets considered django 1.4 only now as well? If so, we should probably switch this over to the python ...

SM smacleod
SM
  1. 
      
  2. djblets/gravatars/__init__.py (Diff revision 1)
     
     
    Is djblets considered django 1.4 only now as well? If so, we should probably switch this over to the python 2.5 hashlib
    1. This change is going into 0.6.x, which is still Django 1.3.
  3. djblets/gravatars/__init__.py (Diff revision 1)
     
     
    What's reason you're returning "", as opposed to None?
    1. None will easily turn into "None" when being serialized into a template or resource payload. Rather than each call site having to do a check and then turning it into a blank string, this will just return a blank string representing no URL.
  4. 
      
SM
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (dcb7332)
Loading...