Summary

Add a get_gravatar_url function in gravatars.

Review Request #3470 — Created Nov. 3, 2012 and submitted Nov. 3, 2012, 11:09 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.6.x

Bugs

2768

Depends On

Reviewers

Groups

djblets

People

Description

Add a get_gravatar_url function in gravatars.

This makes it possible to get the URL without generating an <img/> tag.
It also is smart enough to handle HTTP vs. HTTPS, unlike the previous
implementation.

Testing Done

Tested with a change in Review Board.

Issues

Description	From	Last Updated
Is djblets considered django 1.4 only now as well? If so, we should probably switch this over to the python …	SM smacleod	Nov. 3, 2012, 10:06 p.m.

djblets/gravatars/__init__.py (Diff revision 1)

The issue has been dropped. Show all issues

Is djblets considered django 1.4 only now as well? If so, we should probably switch this over to the python 2.5 hashlib

chipx86 Nov. 3, 2012, 10:04 p.m.

This change is going into 0.6.x, which is still Django 1.3.

djblets/gravatars/__init__.py (Diff revision 1)

What's reason you're returning "", as opposed to None?

chipx86 Nov. 3, 2012, 10:04 p.m.

None will easily turn into "None" when being serialized into a template or resource payload. Rather than each call site having to do a check and then turning it into a blank string, this will just return a blank string representing no URL.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.6.x (dcb7332)