Introduce a file attachment image review UI.
Review Request #3441 — Created Oct. 21, 2012 and submitted
| Information | |
|---|---|
| chipx86 | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard | |
Introduce a file attachment image review UI. This introduces the first real review UI for file attachments. There's a few new JavaScript objects for easily dealing with FileAttachmentComments and FileAttachment-based review UIs. The UI is the same as what we have for screenshots. In fact, the screenshot code has changed to just use the new image review UI code, but with models for working with Screenshot and ScreenshotComments. There's also some new code for registering review UIs, which will make it easier to start developing new UIs. This includes in extensions.
Tested screenshot comment review and file attachment image comment review. This included posting new draft comments, reloading and seeing the comments in the right place, publishing them, and seeing them again. It also included verifying old screenshot comments were in the right place.
| Description | From | Last Updated |
|---|---|---|
|
It might be more consistent as 'get_comments_json'. |
SM smacleod | |
|
"commetns" -> "comments" |
SM smacleod | |
|
The other formats you refer to are those supported by simplejson.dumps, correct? Is there any way we can be more … |
SM smacleod |
Change Summary:
* Removed some test code in ReviewUI.comments_json. * Added some docstrings.
SM
-
-
reviewboard/reviews/ui/base.py (Diff revision 2) It might be more consistent as 'get_comments_json'.
-
-
reviewboard/reviews/ui/base.py (Diff revision 2) The other formats you refer to are those supported by simplejson.dumps, correct? Is there any way we can be more precise about what other formats entails?
-
reviewboard/reviews/ui/base.py (Diff revision 2) Is the plan to allow extensions to call this directly, or will some sort of hook be added?
Change Summary:
* Expanded some documentation to be more clear. * Fixed a typo. * Renamed comments_json to get_comments_json.
Diff: |
Revision 3 (+601 -321)
|
|---|
-
-
reviewboard/static/rb/js/models/regionCommentBlockModel.js (Diff revision 3) What happens in the other code if it gets undefined fields? Should we log something?
-
After trying out this patch, I think you need to add something that imports reviewboard.reviews.ui in something that runs during initial load. Maybe reviewboard/reviews/__init__.py ?
Change Summary:
Fixed the initialization call not getting run. This was due to the __init__.py not being accessed. Now it's treated like any other Django app, and is in RB_BUILTIN_APPS.
Diff: |
Revision 4 (+602 -321)
|
|---|