Add bazaar support to post-review

Review Request #3424 — Created Oct. 17, 2012 and submitted

Information

RBTools
master
773

Reviewers

I updated the change from http://reviews.reviewboard.org/r/1739/ which added support for Bazaar to post-review, but is now out of date.
Ran the unit tests included, and used it locally to submit some changes.
Description From Last Updated

Please move this comment to be above BRANCH_REGEX, and use #s instead of a triple-quoted string.

daviddavid

Remove this line.

daviddavid

Remove this line.

daviddavid

Remove this line. Same for other docstrings below.

daviddavid

Remove this line.

daviddavid
MR
MR
david
  1. This looks pretty great. I have a handful of style comments.
  2. rbtools/clients/bazaar.py (Diff revision 2)
     
     
     
     
     
     
    Please move this comment to be above BRANCH_REGEX, and use #s instead of a triple-quoted string.
  3. rbtools/clients/bazaar.py (Diff revision 2)
     
     
    Remove this line.
  4. rbtools/clients/bazaar.py (Diff revision 2)
     
     
    Remove this line.
  5. rbtools/clients/bazaar.py (Diff revision 2)
     
     
    Remove this line. Same for other docstrings below.
  6. rbtools/clients/tests.py (Diff revision 2)
     
     
    Remove this line.
  7. 
      
MR
SM
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
MR
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (85f43d5). Thanks!
Loading...