Add support for storage backends for SSH keys.

Review Request #3417 — Created Oct. 15, 2012 and submitted

Information

Review Board
release-1.6.x

Reviewers

Add support for storage backends for SSH keys.

The SSH client functionality is now separated from SSH key storage.
SSHClient has no knowledge now of where keys live. It could be on the
file system, in memory, sitting on a gopher server, or whatever else the
storage backend is talking to.

All the file access has been moved to a new FileSSHStorage class.

New unit tests have been added to test the new code paths.
Unit tests all pass.

Tested my local deployment with the SSH-backed Review Board Git repo.
Everything worked fine.

Tested running rbssh manually to connect to servers.
Description From Last Updated

Remove this line

daviddavid

The break statement here is unnecessary

daviddavid

Should this case re-raise the exception?

daviddavid
chipx86
david
  1. 
      
  2. reviewboard/ssh/client.py (Diff revision 2)
     
     
    Show all issues
    Remove this line
  3. reviewboard/ssh/client.py (Diff revision 2)
     
     
     
    Show all issues
    The break statement here is unnecessary
  4. reviewboard/ssh/client.py (Diff revision 2)
     
     
    Show all issues
    Should this case re-raise the exception?
  5. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.6.x (22fdac8)
Loading...