Fixes for Issue 2552
Review Request #3399 — Created Oct. 6, 2012 and discarded — Latest diff uploaded
- URL to diff comments returns 404 if at least one of diff-id and file-id are invalid. - Fixed to use pk when getting a FileDiffResource queryset instead of local id.
Tested on local development server against custom urls.
Diff Revision 1 (Latest)
| reviewboard/static/rb/images/expand.png |
|---|
| reviewboard/static/rb/js/reviews.js |
|---|
| reviewboard/static/rb/js/screenshots.js |
|---|
| reviewboard/static/rb/js/models/abstractCommentBlockModel.js |
|---|
| reviewboard/static/rb/js/models/screenshotCommentBlockModel.js |
|---|
| reviewboard/static/rb/js/views/screenshotCommentBlockView.js |
|---|
| reviewboard/templates/admin/change_form.html |
|---|
| reviewboard/templates/diffviewer/diff_file_fragment.html |
|---|
| reviewboard/templates/diffviewer/expand_link.html |
|---|
| reviewboard/templates/notifications/email_diff_comment_fragment.html |
|---|
| reviewboard/webapi/resources.py |
|---|
| reviewboard/webapi/tests.py |
|---|