Fixes for Issue 2552

Review Request #3399 — Created Oct. 6, 2012 and discarded

Information

Review Board

Reviewers

- URL to diff comments returns 404 if at least one of diff-id and file-id are invalid.
- Fixed to use pk when getting a FileDiffResource queryset instead of local id.
Tested on local development server against custom urls.
MI
chipx86
  1. When writing a summary, make sure it describes in short what is done, rather than referencing a bug number.
  2. 
      
mike_conley
  1. Hm - I'm seeing a lot of stuff in this diff that I don't think belongs.
    
    Have you made sure your master is up to date?
  2. 
      
MI
Review request changed
Status:
Discarded