Summary

Fix for Issue 2327: Added filter in FileDiffCommentResource to select diff comments that match only one file id

Review Request #3377 — Created Sept. 29, 2012 and submitted Sept. 30, 2012, 7:55 a.m.

Information

Owner

Allyshia

Repository

Review Board

Branch

release-1.6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Adding filter to FillDiffCommentResource to only fetch comments for requested file, and not an entire list of comments for every file in a given diffset.

Fixes bug 2327.
Reviewed at http://reviews.reviewboard.org/r/3372/

Testing Done

Manual testing: following the steps described in the issue will no longer
produce the issue.
-checked that this did not affect alternate method for fetching diff comments (ie fetching specific comments for a given diffset)

Issues

Description	From	Last Updated
Can you align the second line with the ( for the function call? Like this: return q.filter(filediff__diffset... filediff__id...	david	Sept. 29, 2012, 12:48 p.m.

Fix it!

reviewboard/webapi/resources.py (Diff revision 1)

An issue was opened. Show all issues

Can you align the second line with the ( for the function call? Like this:

return q.filter(filediff__diffset...
                filediff__id...

Change Summary:

Fixed alignment of args over 2 lines.

Diff:

Revision 2 (+3 -2)

Show changes

reviewboard/webapi/resources.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.6.x (dd5dede). Thanks!