Fix for Issue 2327: Added filter in FileDiffCommentResource to select diff comments that match only one file id

Review Request #3377 — Created Sept. 29, 2012 and submitted

Allyshia
Review Board
release-1.6.x
reviewboard
Adding filter to FillDiffCommentResource to only fetch comments for requested file, and not an entire list of comments for every file in a given diffset.

Fixes bug 2327.
Reviewed at http://reviews.reviewboard.org/r/3372/
Manual testing: following the steps described in the issue will no longer
produce the issue.
-checked that this did not affect alternate method for fetching diff comments (ie fetching specific comments for a given diffset)
Description From Last Updated

Can you align the second line with the ( for the function call? Like this: return q.filter(filediff__diffset... filediff__id...

daviddavid
david
  1. 
      
  2. reviewboard/webapi/resources.py (Diff revision 1)
     
     
     
    Can you align the second line with the ( for the function call? Like this:
    
    return q.filter(filediff__diffset...
                    filediff__id...
  3. 
      
AL
david
  1. Ship It!
  2. 
      
AL
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.6.x (dd5dede). Thanks!
Loading...