-
-
reviewboard/static/rb/js/reviews.js (Diff revision 1) All of these lines shown in reviewboard with big red blocks have trailing whitespace. Please clean this up.
-
reviewboard/static/rb/js/reviews.js (Diff revision 1) Let's just include this description in the above comment. Explain there that we'll prevent it from being part of the URL, but only if there are no open parenthesis characters in the URL.
Issue 2002 - Bug with linkify js
Review Request #3374 — Created Sept. 29, 2012 and submitted
Issue 2002 - Bug with linkify js This further fixes the bug with regards to linkifying text. Now, URLs with anchors (open and close parens, with or without text in between them) work properly. This fix doesn't affect the behaviour observed with url wrapped in parens.
Self tested on own environment with different types of urls - blah blah (http://www.foo.com/) - http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Object.html#clone() - http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Object.html#equals(java.lang.Object) - gwegdss http://www.foo.com/
Description | From | Last Updated |
---|---|---|
var declaration in javascript should follow this style: var a = '', b = ''; |
ME medanat | |
All of these lines shown in reviewboard with big red blocks have trailing whitespace. Please clean this up. |
|
|
Remove trailing white space (the red lines). |
ME medanat | |
No need for two new lines here. Should be just 1. |
ME medanat | |
Let's just include this description in the above comment. Explain there that we'll prevent it from being part of the … |
|
|
While this comment is relevant, you shouldn't include the bug author in the comment. Just explain what this piece of … |
ME medanat | |
By "paren", do you mean "parentheses"? If so, please use the full word for clarity. |
ME medanat | |
This declaration could be declared by the vars 'extra' and 'parts'; |
ME medanat | |
A few trailing spaces. |
ME medanat |
-
A few style issues I ran into.
-
reviewboard/static/rb/js/reviews.js (Diff revision 1) var declaration in javascript should follow this style: var a = '', b = '';
-
-
reviewboard/static/rb/js/reviews.js (Diff revision 1) No need for two new lines here. Should be just 1.
-
reviewboard/static/rb/js/reviews.js (Diff revision 1) While this comment is relevant, you shouldn't include the bug author in the comment. Just explain what this piece of code is doing or what purpose it's serving.
-
reviewboard/static/rb/js/reviews.js (Diff revision 1) By "paren", do you mean "parentheses"? If so, please use the full word for clarity.
-
reviewboard/static/rb/js/reviews.js (Diff revision 1) This declaration could be declared by the vars 'extra' and 'parts';
-
Well done! Remove the last trailing spaces and you're set! One thing I always do is check the diff viewer before submitting a review to see if there are trailing spaces or other obvious issues.
-