-
-
/trunk/reviewboard/contrib/tools/post-review (Diff revision 1) You should extend the username regex to support "-". This should probably also match the regex at the beginning of the string instead of checking anywhere in the string.
Allow Usernames in Subversion Repo URL
Review Request #337 — Created April 4, 2008 and submitted
We use svn served over ssh, so most users have working copies checked out using a URL like svn+ssh://durin42@host... which means that post-review was passing the wrong repository to the ReviewBoard server. This small patch fixes that problem for us.
I've been posting reviews with this for over a week, and some other users have been using it too.
PL
-
For what it's worth, my patch (review 351), assuming it gets approved, should fix this in a more general way...
-
Committed as r1314. This may be superseded by the UUID patch once that goes in, but this should improve things in the meantime. Just as a note, it looks like your editor converted every 8-space sequence into a tab character. This didn't show up in RB because we don't show whitespace changes like that, but it made it basically impossible to apply your patch as-is. I suggest you look up how to turn that off -- python style guidelines are pretty specific that having any tab characters in the source is broken. Thanks!