Increase hit target for expand/collapse button

Review Request #3365 — Created Sept. 28, 2012 and submitted

aam1r
Review Board
reviewboard
Increase hit target for expand/collapse button

Increase the size of the expand and collapse button images to make it
a bigger hit target. This reduces the chances of someone accidentally 
clicking the user's name while trying to expand/collapse a review.

Fixes Issue #2358
Tested it locally on Chrome Version 22.0.1229 (Mac)
Loading file attachments...

Description From Last Updated

Can you tweak the CSS to center these vertically within the bar? There's too much padding on top and not ...

daviddavid
chipx86
  1. Maybe we should make the image itself bigger, by about 2 pixels on each side.
    1. I will give that a try. By each side, do you think we should also increase the height (by a total of 4 pixels)?
    2. Yep.
  2. 
      
AA
david
  1. Can you add a new screenshot?
  2. 
      
AA
david
  1. Do you mind not cropping the screenshots quite as much? I'd like to see more area.
    
    Please also add the images you changed as file attachments to the review request.
  2. 
      
AA
david
  1. 
      
  2. Can you tweak the CSS to center these vertically within the bar? There's too much padding on top and not enough on the bottom.
  3. 
      
AA
david
  1. Ship It!
  2. 
      
AA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (423886f). Thanks!
Loading...