Increase hit target for expand/collapse button
Review Request #3365 — Created Sept. 28, 2012 and submitted
Information | |
---|---|
aam1r | |
Review Board | |
Reviewers | |
reviewboard | |
Increase hit target for expand/collapse button Increase the size of the expand and collapse button images to make it a bigger hit target. This reduces the chances of someone accidentally clicking the user's name while trying to expand/collapse a review. Fixes Issue #2358
Tested it locally on Chrome Version 22.0.1229 (Mac)
Description | From | Last Updated |
---|---|---|
Can you tweak the CSS to center these vertically within the bar? There's too much padding on top and not … |
|
AA
Change Summary:
Increase sizes of images by 2 pixels on each side to increase hit target. Adjusted CSS accordingly to reflect the new width and height.
Description: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+5 -4) |
AA
Change Summary:
Added screenshots of changes from revision 2
-
Screenshot Captions:
after.png: - After + After (rev1)
Screenshots: |
|
---|
-
Do you mind not cropping the screenshots quite as much? I'd like to see more area. Please also add the images you changed as file attachments to the review request.
AA
Change Summary:
Tweaked CSS padding settings to vertically center expand/collapse buttons as well as the content beside the buttons.
Diff: |
Revision 3 (+11 -5) |
||||
---|---|---|---|---|---|
Screenshots: |
|