Summary

Fix for --guess-summary doesn't work when summary has newline characters in it

Review Request #3358 — Created Sept. 27, 2012 and submitted Oct. 7, 2012, 11:56 a.m.

Information

Owner

mrkam

Repository

RBTools

Branch

Bugs

2703

Depends On

Reviewers

Groups

rbtools

People

Description

Testing Done

Used this to file many review requests that didn't work before.

Issues

Description	From	Last Updated
Why not just put the replace() call inside self.extract_summary? Then you should be able to just do it once. Also, …	david	Oct. 2, 2012, 3:02 a.m.

rbtools/clients/mercurial.py (Diff revision 1)

The issue has been resolved. Show all issues

Why not just put the replace() call inside self.extract_summary? Then you should be able to just do it once.

Also, please check the diff for trailing whitespace (all those big red things you see on RB)

Change Summary:

Improved the diff according to comments.

Diff:

Revision 2 (+1 -1)

Show changes

rbtools/clients/mercurial.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (423b9bb). Thanks!