Fix parsing of SVN diffs with property changes.

Review Request #3347 — Created Sept. 24, 2012 and submitted

chipx86
Review Board
release-1.6.x
2359
reviewboard
Fix parsing of SVN diffs with property changes.

SVN diffs with property changes broke diff parsing. We now handle this
properly. We don't show the changes in the diff viewer, but we at least
don't fail miserably now.

Property changes in diffs have only recently gained any kind of
parseable format, it appears, but more work needs to be done to look
into whether we can make any of use it.
Unit tests pass.
david
  1. Ship It!
  2. 
      
SM
  1. Only thing is the multi-line strings. All good otherwise.
  2. reviewboard/scmtools/tests.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Parentheses instead of \
  3. 
      
chipx86
chipx86
SM
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

MX
  1. 
      
  2. reviewboard/diffviewer/parser.py (Diff revision 3)
     
     
    Shouldn't the 2nd parameter be "linenum", not "linenu"--otherwise what will the return on line 174 return?
    1. Good catch. Fortunately I caught it before releasing too, so that won't break anybody. Thanks!
  3. 
      
Loading...