Summary:

Fix parsing of SVN diffs with property changes.

Review Request #3347 — Created Sept. 23, 2012 and submitted Sept. 24, 2012, 9:33 p.m.

Information
Owner:	chipx86
Repository:	Review Board
Branch:	release-1.6.x
Bugs:	2359
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

Fix parsing of SVN diffs with property changes.

SVN diffs with property changes broke diff parsing. We now handle this
properly. We don't show the changes in the diff viewer, but we at least
don't fail miserably now.

Property changes in diffs have only recently gained any kind of
parseable format, it appears, but more work needs to be done to look
into whether we can make any of use it.

Testing Done

Unit tests pass.

Ship it!

```
Ship It!
```

Ship it!

Only thing is the multi-line strings. All good otherwise.

reviewboard/scmtools/tests.py (Diff revision 1)

Parentheses instead of \

Change Summary:

Fixed to work with both SVN 1.6 and 1.7 property change diffs.

Diff:

Revision 2 (+134 -5)

Show changes

	reviewboard/diffviewer/parser.py
	reviewboard/scmtools/svn.py
	reviewboard/scmtools/tests.py

Change Summary:

Synced with release-1.6.x.

Diff:

Revision 3 (+134 -5)

Show changes

	reviewboard/diffviewer/parser.py
	reviewboard/scmtools/svn.py
	reviewboard/scmtools/tests.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

reviewboard/diffviewer/parser.py (Diff revision 3)

Shouldn't the 2nd parameter be "linenum", not "linenu"--otherwise what will the return on line 174 return?

chipx86 Sept. 27, 2012, 12:32 a.m.

Good catch. Fortunately I caught it before releasing too, so that won't break anybody. Thanks!