Rewrite our screenshot review UI and introduce generic review infrastructure.

Review Request #3342 — Created Sept. 23, 2012 and submitted

Information

Review Board

Reviewers

Rewrite our screenshot review UI and introduce generic review infrastructure.

The screenshot review support has been rewritten to have a nice
model/view separation and to abstract much of the review process into
generic models and views.

There's now a few new classes: AbstractCommentBlock, AbstractCommentBlockView,
AbstractReviewable, and AbstractReviewableView. These handle the basics
of creating review UIs and comment blocks.

The screenshot subclasses, as a result, are fairly minimal for the most
part.

From here on out, it should be easier to create review UIs for custom
mimetypes. This will get even easier as more of our review
infrastructure is moved to new Backbone models and views.
Tested all aspects of screenshot commenting. Loading, creating, deleting.
Drafts, non-drafts. 
Description From Last Updated

Can you merge these? return $('') .appendTo(list) .text(comment.text.truncate());

daviddavid

===?

daviddavid
david
  1. 
      
  2. Show all issues
    Can you merge these?
    
    return $('<li>')
           .appendTo(list)
           .text(comment.text.truncate());
  3. Should this be the same this?
    
    this this this?
    1. It is, but it's implicit due to listening to this's event. I'm going to add an explicit context (this) as a parameter to once() so we can guarantee 'this'.
  4. Show all issues
    ===?
  5. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed