-
-
reviewboard/static/rb/js/views/abstractCommentBlockView.js (Diff revision 1) Can you merge these? return $('<li>') .appendTo(list) .text(comment.text.truncate()); -
reviewboard/static/rb/js/views/abstractReviewableView.js (Diff revision 1) Should this be the same this? this this this?
-
Rewrite our screenshot review UI and introduce generic review infrastructure.
Review Request #3342 — Created Sept. 23, 2012 and submitted
Rewrite our screenshot review UI and introduce generic review infrastructure. The screenshot review support has been rewritten to have a nice model/view separation and to abstract much of the review process into generic models and views. There's now a few new classes: AbstractCommentBlock, AbstractCommentBlockView, AbstractReviewable, and AbstractReviewableView. These handle the basics of creating review UIs and comment blocks. The screenshot subclasses, as a result, are fairly minimal for the most part. From here on out, it should be easier to create review UIs for custom mimetypes. This will get even easier as more of our review infrastructure is moved to new Backbone models and views.
Tested all aspects of screenshot commenting. Loading, creating, deleting. Drafts, non-drafts.
Change Summary:
* Synced to master. * Merged some statements by using jQuery chaining. * Explicitly passed a context to a call to once() for 'this'. * Changed a comparison to use ===.