Fix several issues with the new site style.

Review Request #3336 — Created Sept. 20, 2012 and submitted

chipx86
Review Board
reviewboard
Fix several issues with the new site style.

The dropdown menus at the top of the page should no longer sit below
other UI elements. In fact, the whole z-order of elements is now defined
in one place, so that we're not using random numbers all over.

The borders of the review request action menus are now set correctly.

Primary column contents in the admin UI are no longer inheriting the
column header styling.

The trophies no longer cause the review request action bar to shift
down.
Tested each of these cases in Chrome and Firefox.
Description From Last Updated

Maybe #accountnav li should also have: min-width: @headerbar-menu-min-width; Otherwise '#accountnav li ul' can be wider than the parent '#accountnav li' ...

ME medanat
SM
  1. Ship It!
  2. 
      
ME
  1. 
      
  2. reviewboard/static/rb/css/common.less (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Maybe #accountnav li should also have: 
    
    min-width: @headerbar-menu-min-width;
    
    Otherwise '#accountnav li ul' can be wider than the parent '#accountnav li' appearing odd in some cases.
    1. Yep, I tested with that. I think it looks fine. Definitely better than having the main links at the top being too wide (which still doesn't guarantee that the menu won't be longer).
  3. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (954fdc1)
Loading...