Summary

Fix several issues with the new site style.

Review Request #3336 — Created Sept. 20, 2012 and submitted Sept. 20, 2012, 10:22 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix several issues with the new site style.

The dropdown menus at the top of the page should no longer sit below
other UI elements. In fact, the whole z-order of elements is now defined
in one place, so that we're not using random numbers all over.

The borders of the review request action menus are now set correctly.

Primary column contents in the admin UI are no longer inheriting the
column header styling.

The trophies no longer cause the review request action bar to shift
down.

Testing Done

Tested each of these cases in Chrome and Firefox.

Issues

Description	From	Last Updated
Maybe #accountnav li should also have: min-width: @headerbar-menu-min-width; Otherwise '#accountnav li ul' can be wider than the parent '#accountnav li' …	ME medanat	Sept. 20, 2012, 10:19 p.m.

Ship it!

```
Ship It!
```

reviewboard/static/rb/css/common.less (Diff revision 1)

The issue has been dropped. Show all issues

Maybe #accountnav li should also have: 

min-width: @headerbar-menu-min-width;

Otherwise '#accountnav li ul' can be wider than the parent '#accountnav li' appearing odd in some cases.

chipx86 Sept. 20, 2012, 10:19 p.m.

Yep, I tested with that. I think it looks fine. Definitely better than having the main links at the top being too wide (which still doesn't guarantee that the menu won't be longer).

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (954fdc1)