Summary

Add a session id option to the API

Review Request #3331 — Created Sept. 19, 2012 and submitted Sept. 20, 2012, 11:26 p.m.

Information

Owner

smacleod

Repository

RBTools

Branch

api

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Allows a session id to be provided when using the API.

Passing a session id in the 'session' argument of the sync transport will cause the API to use the corresponding session.

Dependent upon /r/3318

Testing Done

Issues

Description	From	Last Updated
Would be nice to just doc what's happening right here.	chipx86	Sept. 20, 2012, 12:46 p.m.
Might be nice to define this as a constant somewhere.	chipx86	Sept. 20, 2012, 12:49 p.m.
Hmm, this isn't always correct. We should factor in the Review Board root for it. It could be a subdirectory …	chipx86	Sept. 20, 2012, 12:46 p.m.
Can we do one per line?	chipx86	Sept. 20, 2012, 12:50 p.m.

rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Would be nice to just doc what's happening right here.
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Might be nice to define this as a constant somewhere.
```

rbtools/api/request.py (Diff revision 1)

The issue has been resolved. Show all issues

Hmm, this isn't always correct. We should factor in the Review Board root for it. It could be a subdirectory install.

SM

smacleod Sept. 20, 2012, 12:54 p.m.
```
Nice catch.
```

rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we do one per line?
```
1. SM
  
  smacleod Sept. 20, 2012, 12:54 p.m.

Change Summary:

Updated based on Christian's review.

Diff:

Revision 2 (+43 -5)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to api (ad6b7ad)