Add support for ClearCase snapshot views.

Review Request #3322 — Created Sept. 6, 2012 and submitted

Information

Review Board
master

Reviewers

Add support for ClearCase snapshot views. This is especially useful for Windows installations due to the pathname limitation.
Tested on Windows ReviewBoard 1.6.11 installation.

Done some basic tests on Linux.
Description From Last Updated

Instead of returning strings here, can you define some constants? You can do that like this: VIEW_SNAPSHOT, VIEW_DYNAMIC, VIEW_UNKNOWN = …

daviddavid

Add a space between # and the text.

daviddavid

Add a space between # and the text.

daviddavid

This shouldn't be necessary, since NamedTemporaryFile defaults to delete=True

daviddavid

Indent only 4 spaces

daviddavid
david
  1. 
      
  2. reviewboard/scmtools/clearcase.py (Diff revision 1)
     
     
     
     
     
    Instead of returning strings here, can you define some constants? You can do that like this:
    
    VIEW_SNAPSHOT, VIEW_DYNAMIC, VIEW_UNKNOWN = range(3)
  3. reviewboard/scmtools/clearcase.py (Diff revision 1)
     
     
    Add a space between # and the text.
  4. reviewboard/scmtools/clearcase.py (Diff revision 1)
     
     
    Add a space between # and the text.
  5. reviewboard/scmtools/clearcase.py (Diff revision 1)
     
     
     
    This shouldn't be necessary, since NamedTemporaryFile defaults to delete=True
  6. reviewboard/scmtools/clearcase.py (Diff revision 1)
     
     
     
     
     
    Indent only 4 spaces
  7. 
      
DE
david
  1. Ship It!
  2. 
      
DE
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.6.x (ae82e17). Thanks!
Loading...