Summary

Add support for ClearCase snapshot views.

Review Request #3322 — Created Sept. 6, 2012 and submitted Sept. 20, 2012, 2:45 a.m.

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description

Add support for ClearCase snapshot views. This is especially useful for Windows installations due to the pathname limitation.

Testing Done

Tested on Windows ReviewBoard 1.6.11 installation.

Done some basic tests on Linux.

Issues

Description	From	Last Updated
Instead of returning strings here, can you define some constants? You can do that like this: VIEW_SNAPSHOT, VIEW_DYNAMIC, VIEW_UNKNOWN = …	david	Sept. 17, 2012, 6:57 a.m.
Add a space between # and the text.	david	Sept. 17, 2012, 6:57 a.m.
Add a space between # and the text.	david	Sept. 17, 2012, 6:57 a.m.
This shouldn't be necessary, since NamedTemporaryFile defaults to delete=True	david	Sept. 17, 2012, 6:57 a.m.
Indent only 4 spaces	david	Sept. 17, 2012, 6:57 a.m.

reviewboard/scmtools/clearcase.py (Diff revision 1)

The issue has been resolved. Show all issues

Instead of returning strings here, can you define some constants? You can do that like this:

VIEW_SNAPSHOT, VIEW_DYNAMIC, VIEW_UNKNOWN = range(3)

reviewboard/scmtools/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Add a space between # and the text.
```
reviewboard/scmtools/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Add a space between # and the text.
```
reviewboard/scmtools/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This shouldn't be necessary, since NamedTemporaryFile defaults to delete=True
```
reviewboard/scmtools/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Indent only 4 spaces
```

Change Summary:

Fix issues pointed out by David Trowbridge.

Diff:

Revision 2 (+112 -19)

Ship it!