RBTools API: Fix root template URLs and construction of list items

Review Request #3318 — Created Aug. 30, 2012 and submitted

smacleod
RBTools
api
rbtools
The regex for using the templates in the root resource was failing when the template contained more than one variable. The new regex matches properly.

A blank URL was being passed to item resources constructed from a list resource. This caused issues with some of the custom methods in resource specific base classes. A proper URL will now be guessed from the items self link.


Description From Last Updated

You can fit more on each line. Should be able to get 2 lines total.

chipx86chipx86

We'd only hit KeyError, right? We should explicitly check for that.

chipx86chipx86
chipx86
  1. 
      
  2. rbtools/api/transport/sync.py (Diff revision 1)
     
     
     
     
    You can fit more on each line. Should be able to get 2 lines total.
  3. rbtools/api/transport/sync.py (Diff revision 1)
     
     
    We'd only hit KeyError, right? We should explicitly check for that.
  4. 
      
SM
chipx86
  1. Ship It!
  2. 
      
SM
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to api (a9b0e60)
Loading...