Summary

RBTools API: Fix root template URLs and construction of list items

Review Request #3318 — Created Aug. 30, 2012 and submitted Sept. 21, 2012, 12:17 a.m.

Information

Owner

smacleod

Repository

RBTools

Branch

api

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The regex for using the templates in the root resource was failing when the template contained more than one variable. The new regex matches properly.

A blank URL was being passed to item resources constructed from a list resource. This caused issues with some of the custom methods in resource specific base classes. A proper URL will now be guessed from the items self link.

Testing Done

Issues

Description	From	Last Updated
You can fit more on each line. Should be able to get 2 lines total.	chipx86	Sept. 20, 2012, 11:32 a.m.
We'd only hit KeyError, right? We should explicitly check for that.	chipx86	Sept. 20, 2012, 11:34 a.m.

rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
You can fit more on each line. Should be able to get 2 lines total.
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We'd only hit KeyError, right? We should explicitly check for that.
```

Change Summary:

Updated based on Christian's review.

Diff:

Revision 2 (+9 -4)

Show changes

	rbtools/api/resource.py
	rbtools/api/transport/sync.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to api (a9b0e60)