-
-
rbtools/api/resource.py (Diff revision 1) For each of these that has any parameters, it might be nice to just specify a paramname= prefix for each value. Helps with any debugging.
__repr__ methods for API client
Review Request #3293 — Created Aug. 19, 2012 and submitted
Provides __repr__() methods for the synchronous API client. Also fixes a bug causing the provided user agent not to be used.
| Description | From | Last Updated |
|---|---|---|
|
For each of these that has any parameters, it might be nice to just specify a paramname= prefix for each … |
 chipx86
|
|
|
Rather than calling repr(...), just use %r in the format string for that parameter. Same with the ones below. |
chipx86
|
|
|
Can you do one per line while we're here for the keyword args? |
chipx86
|
|
|
Formatting feels weird. Can you instead indent 4 spaces from the 'return' ? |
chipx86
|
SM
Change Summary:
Updated based on Christian's review. Patch is now on the api branch.
Description: |
|
|||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Branch: |
|
|||||||||||||||
Diff: |
Revision 2 (+65 -1) |
-
-
rbtools/api/resource.py (Diff revision 2) Rather than calling repr(...), just use %r in the format string for that parameter. Same with the ones below.
-
rbtools/api/transport/sync.py (Diff revision 2) Can you do one per line while we're here for the keyword args?
-
rbtools/api/transport/sync.py (Diff revision 2) Formatting feels weird. Can you instead indent 4 spaces from the 'return' ?