__repr__ methods for API client

Review Request #3293 — Created Aug. 19, 2012 and submitted

smacleod
RBTools
api
rbtools
Provides __repr__() methods for the synchronous API client.

Also fixes a bug causing the provided user agent not to be used.


Description From Last Updated

For each of these that has any parameters, it might be nice to just specify a paramname= prefix for each ...

chipx86chipx86

Rather than calling repr(...), just use %r in the format string for that parameter. Same with the ones below.

chipx86chipx86

Can you do one per line while we're here for the keyword args?

chipx86chipx86

Formatting feels weird. Can you instead indent 4 spaces from the 'return' ?

chipx86chipx86
chipx86
  1. 
      
  2. rbtools/api/resource.py (Diff revision 1)
     
     
    For each of these that has any parameters, it might be nice to just specify a paramname= prefix for each value. Helps with any debugging.
  3. 
      
SM
chipx86
  1. 
      
  2. rbtools/api/resource.py (Diff revision 2)
     
     
     
     
     
     
    Rather than calling repr(...), just use %r in the format string for that parameter. Same with the ones below.
  3. rbtools/api/transport/sync.py (Diff revision 2)
     
     
    Can you do one per line while we're here for the keyword args?
  4. rbtools/api/transport/sync.py (Diff revision 2)
     
     
     
     
     
     
     
    Formatting feels weird. Can you instead indent 4 spaces from the 'return' ?
  5. 
      
SM
chipx86
  1. Ship It!
  2. 
      
SM
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to api (c2e25a6)
Loading...