Summary

repr methods for API client

Review Request #3293 — Created Aug. 20, 2012 and submitted Sept. 21, 2012, 7:24 a.m.

Owner

Repository

RBTools

Branch

api

Bugs

Depends On

Groups

People

Description

Provides __repr__() methods for the synchronous API client.

Also fixes a bug causing the provided user agent not to be used.

Testing Done

Issues

Description	From	Last Updated
For each of these that has any parameters, it might be nice to just specify a paramname= prefix for each …	chipx86	Aug. 30, 2012, 9:24 p.m.
Rather than calling repr(...), just use %r in the format string for that parameter. Same with the ones below.	chipx86	Sept. 20, 2012, 6:21 p.m.
Can you do one per line while we're here for the keyword args?	chipx86	Sept. 20, 2012, 6:21 p.m.
Formatting feels weird. Can you instead indent 4 spaces from the 'return' ?	chipx86	Sept. 20, 2012, 6:18 p.m.

rbtools/api/resource.py (Diff revision 1)

The issue has been resolved. Show all issues

For each of these that has any parameters, it might be nice to just specify a paramname= prefix for each value. Helps with any debugging.

Change Summary:

Updated based on Christian's review. Patch is now on the api branch.

Description:

		Provides repr() methods for the synchronous API client.

		Also fixes a bug causing the provided user agent not to be used.
-
-		Dependent on parent diff in /r/3184.

Branch:

master

api

Diff:

	rbtools/api/resource.py
	rbtools/api/transport/sync.py

rbtools/api/resource.py (Diff revision 2)

The issue has been resolved. Show all issues

Rather than calling repr(...), just use %r in the format string for that parameter. Same with the ones below.

rbtools/api/transport/sync.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you do one per line while we're here for the keyword args?
```

rbtools/api/transport/sync.py (Diff revision 2)

The issue has been resolved. Show all issues

Formatting feels weird. Can you instead indent 4 spaces from the 'return' ?

Change Summary:

Updated based on Christian's review.

Diff:

	rbtools/api/resource.py
	rbtools/api/transport/sync.py

Ship it!

__repr__ methods for API client